Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[temp] feat: add download template button to taxonomy list #7

Conversation

rpenido
Copy link
Member

@rpenido rpenido commented Nov 7, 2023

WIP

renovate bot and others added 8 commits November 6, 2023 13:26
…x#647)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#650)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…x#641)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…openedx#651)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v1.175.1 (openedx#663)

* fix(deps): update dependency @edx/frontend-lib-content-components to v1.175.1

* fix: upgrade paragon

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: KristinAoki <[email protected]>
@rpenido rpenido force-pushed the rpenido/fal-3532-download-template branch 2 times, most recently from 71693d7 to 7b6d7ad Compare November 8, 2023 19:14
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (chris/FAL-3528-taxonomy-export-menu@77a355e). Click here to learn what that means.

❗ Current head 7b6d7ad differs from pull request most recent head 80d737b. Consider uploading reports for the commit 80d737b to get more accurate results

Additional details and impacted files
@@                          Coverage Diff                           @@
##             chris/FAL-3528-taxonomy-export-menu       #7   +/-   ##
======================================================================
  Coverage                                       ?   88.06%           
======================================================================
  Files                                          ?      421           
  Lines                                          ?     6651           
  Branches                                       ?     1431           
======================================================================
  Hits                                           ?     5857           
  Misses                                         ?      769           
  Partials                                       ?       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This works great @rpenido .

Since this PR isn't dependent on anything in chris/FAL-3528-taxonomy-export-menu, you should be able to create an upstream PR by just cherry-picking your change onto latest master.

  • I tested this on my devstack to ensure I could download the JSON and CSV template files.
  • I read through the code
  • I checked for accessibility issues by using my keyboard only to naviate.
  • Includes documentation
  • All strings are translatable.

@rpenido rpenido force-pushed the rpenido/fal-3532-download-template branch from 7b6d7ad to 80d737b Compare November 9, 2023 12:22
@rpenido
Copy link
Member Author

rpenido commented Nov 9, 2023

Since this PR isn't dependent on anything in chris/FAL-3528-taxonomy-export-menu, you should be able to create an upstream PR by just cherry-picking your change onto latest master.

I failed to realize that. Thank you @pomegranited!

Closed in favor of:

@rpenido rpenido closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants