-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[temp] feat: add download template button to taxonomy list #7
[temp] feat: add download template button to taxonomy list #7
Conversation
…x#647) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#650) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…x#641) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…openedx#651) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v1.175.1 (openedx#663) * fix(deps): update dependency @edx/frontend-lib-content-components to v1.175.1 * fix: upgrade paragon --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: KristinAoki <[email protected]>
71693d7
to
7b6d7ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chris/FAL-3528-taxonomy-export-menu #7 +/- ##
======================================================================
Coverage ? 88.06%
======================================================================
Files ? 421
Lines ? 6651
Branches ? 1431
======================================================================
Hits ? 5857
Misses ? 769
Partials ? 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This works great @rpenido .
Since this PR isn't dependent on anything in chris/FAL-3528-taxonomy-export-menu, you should be able to create an upstream PR by just cherry-picking your change onto latest master
.
- I tested this on my devstack to ensure I could download the JSON and CSV template files.
- I read through the code
- I checked for accessibility issues by using my keyboard only to naviate.
- Includes documentation
- All strings are translatable.
7b6d7ad
to
80d737b
Compare
I failed to realize that. Thank you @pomegranited! Closed in favor of: |
WIP